feat: auto-tls for websockets #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #2798 and probably some others. |
3 tasks
achingbrain
force-pushed
the
feat/websockets-auto-tls
branch
from
fc491dc to
3b2c111
Compare
Starts a tcp server on the listen port and hands connections off to internal http or https servers (depdending on connection type). Upgrade requests from both servers are handled by a websocket server. The https server is enabled when either a secure websocket address is listened to explicitly, or when a TLS certificate is provisioned by another libp2p component, likely `@libp2p/auto-tls`. This means we don't need to add another port mapping for the https server since we run http and https over the same port.
achingbrain
force-pushed
the
feat/websockets-auto-tls
branch
from
3b2c111 to
b97e91a
Compare
achingbrain
commented
Nov 25, 2024
|
Merging to get a rc out for further testing |
Merged
acul71
pushed a commit
to acul71/js-libp2p-fork
that referenced
this pull request
Dec 1, 2024
Starts a tcp server on the listen port and hands connections off to internal http or https servers (depdending on connection type). Upgrade requests from both servers are handled by a websocket server. The https server is enabled when either a secure websocket address is listened to explicitly, or when a TLS certificate is provisioned by another libp2p component, likely `@libp2p/auto-tls`. This means we don't need to add another port mapping for the https server since we run http and https over the same port.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts a tcp server on the listen port and hands connections off to internal http or https servers (depdending on connection type).
Upgrade requests from both servers are handled by a websocket server.
The https server is enabled when either a secure websocket address is listened to explicitly, or when a TLS certificate is provisioned by another libp2p component, likely
@libp2p/auto-tls.This means we don't need to add another port mapping for the https server since we run http and https over the same port.
Change checklist